chore: make UI dev easier #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: fix(meta): remove `runtime.HttpBodyMarshaler` from gateway stack (#1277)
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 79.82% 79.63% -0.19%
==========================================
Files 42 42
Lines 3217 3217
==========================================
- Hits 2568 2562 -6
- Misses 521 525 +4
- Partials 128 130 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of https://vitejs.dev/guide/backend-integration.html and allows us to still load the UI on port
:8080when developing while taking advantage of hot reloading provided by Vite.The instructors are updated in
DEVELOPMENT.md, but basically the steps are:npm run devwhere you have theflipt-uirepository checked out. This will start a development server on port5173and proxy API requests to the Flipt API on port8080.mage devfrom the this repository. This will create a dev build that will serve the UI from the development server, while still making it accessible on port8080../bin/flipt --config ./config/local.yml. This will enable CORS with the correct configuration and start the server on port8080.http://localhost:8080to see the UI.flipt-uirepository will be picked up by the development server and the UI will be reloaded.